Fix view migration issue #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkistner
force-pushed
the
fix-triggers-migration
branch
from
9516c74 to
3d5d75f
Compare
Rentacookie
approved these changes
Dec 10, 2024
This was referenced Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are triggers referring to PowerSync views, the current migration that drops existing views can cause issues (see the test). This would manifest in an error such as:
This changes the migration to only drop the triggers, instead of completely dropping the views. (Technically we do still drop the views, but they are immediately re-created, avoiding the issue.)
See the Discord thread for context.