[Fix] Refresh Credentials #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manrich121
previously approved these changes
Apr 8, 2024
DominicGBauer
previously approved these changes
Apr 8, 2024
DominicGBauer
approved these changes
Apr 8, 2024
Manrich121
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the
PowerSyncBackendConnectorwould not clear the pendingfetchRequestafter it resolved. This would result in the same cached credentials being used after they were expired or invalidated.Notice subsequent connections immediately get the response that the (re-used) token is expiring
Additional changes
sync/streamresponses.streamingSynclevelTesting
A short token lifetime of 30 seconds was used. The video below shows how the sync stream correctly reconnects.
refreshtokens.mp4