Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added WithPayDate method to ListDividendsParams #430

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Added WithPayDate method to ListDividendsParams #430

merged 4 commits into from
Jun 24, 2024

Conversation

justinpolygon
Copy link
Contributor

@justinpolygon justinpolygon commented Jun 18, 2024 •
edited
Loading

Fixes #425. Added helper vs manually changing ListDividendsParams.

This will enable the following:

params := models.ListDividendsParams{}.WithPayDate(models.EQ, models.Date(date))

@justinpolygon justinpolygon merged commit 0afa540 into master Jun 24, 2024
16 checks passed
@justinpolygon justinpolygon deleted the jw-add-withpaydate-method branch June 24, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmoghaddam385 mmoghaddam385 mmoghaddam385 approved these changes

@morningvera morningvera Awaiting requested review from morningvera morningvera is a code owner

@jbonzo jbonzo Awaiting requested review from jbonzo jbonzo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

models.ListDividendsParams does not have a WithPayDate option method
3 participants
@justinpolygon @mmoghaddam385 @actions-user