Update ListOptionsChainParams.WithStrikePrice to support comparators #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinpolygon
requested review from
morningvera,
mmoghaddam385 and
jbonzo
as code owners
Fix comment
mmoghaddam385
approved these changes
May 8, 2024
|
Thank you. When we do the release notes I'll call this out and do a major version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change to
models.ListOptionsChainParams.models.ListOptionsChainParamsthat adds support for strike price comparators via things like.WithStrikePrice("gte", 500.00)andWithStrikePrice("lte", 600.00). A customer wanted to filter using the additional params but couldn't figure out the example. So, I wanted to update the example and found that we didn't support this without directly modifying ListOptionsChainParams with a pointer.