Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a link to Toggle VAT number field #4222

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

apsinghdev
Copy link
Contributor

fixes: #4130

This PR adds a link Add Tax Id to toggle the input box for the Tax Id.

Here is how it looks:

Screen.Recording.2024-10-18.at.11.44.02.PM.mov

Copy link

vercel bot commented Oct 19, 2024

@apsinghdev is attempting to deploy a commit to the polar-sh Team on Vercel.

A member of the Team first needs to authorize it.

@apsinghdev
Copy link
Contributor Author

@birkjernstrom Please have a look and let me know your thoughts. Thanks!

@apsinghdev apsinghdev force-pushed the feat/toggle-vat branch 2 times, most recently from 38b24c4 to c929d6a Compare October 22, 2024 18:39
@frankie567
Copy link
Member

Thank you @apsinghdev 👍 I've tweaked the PR a bit to match our code style, but that was really helpful, thanks!

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
polar ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 3:27pm
polar-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 3:27pm

@frankie567 frankie567 enabled auto-merge (rebase) October 24, 2024 14:42
@frankie567 frankie567 merged commit 8c10184 into polarsource:main Oct 24, 2024
5 of 8 checks passed
@apsinghdev
Copy link
Contributor Author

Thank you @apsinghdev 👍 I've tweaked the PR a bit to match our code style, but that was really helpful, thanks!

Thanks! I'll keep in mind Polar's code style in the next PRs. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkout: Toggle VAT number field
2 participants