server/subscription: tweak min/max length of benefit description

polarsource · Nov 2, 2023 · 2f4879f · 2f4879f · vercel · Nov 2, 2023
1 parent 8b06973
commit 2f4879f
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/server/polar/subscription/schemas.py b/server/polar/subscription/schemas.py
@@ -19,14 +19,19 @@
 TIER_NAME_MIN_LENGTH = 3
 TIER_NAME_MAX_LENGTH = 24
 TIER_DESCRIPTION_MAX_LENGTH = 240
-BENEFIT_DESCRIPTION_MAX_LENGTH = 120
+BENEFIT_DESCRIPTION_MIN_LENGTH = 3
+BENEFIT_DESCRIPTION_MAX_LENGTH = 42
 
 
 # SubscriptionBenefitCreate
 
 
 class SubscriptionBenefitCreateBase(Schema):
-    description: str = Field(..., max_length=BENEFIT_DESCRIPTION_MAX_LENGTH)
+    description: str = Field(
+        ...,
+        min_length=BENEFIT_DESCRIPTION_MIN_LENGTH,
+        max_length=BENEFIT_DESCRIPTION_MAX_LENGTH,
+    )
     organization_id: UUID4 | None = None
     repository_id: UUID4 | None = None
     properties: SubscriptionBenefitProperties
@@ -70,7 +75,11 @@ class SubscriptionBenefitCustomCreate(SubscriptionBenefitCreateBase):
 
 
 class SubscriptionBenefitUpdateBase(Schema):
-    description: str | None = Field(None, max_length=BENEFIT_DESCRIPTION_MAX_LENGTH)
+    description: str | None = Field(
+        None,
+        min_length=BENEFIT_DESCRIPTION_MIN_LENGTH,
+        max_length=BENEFIT_DESCRIPTION_MAX_LENGTH,
+    )
 
 
 class SubscriptionBenefitBuiltinUpdate(SubscriptionBenefitUpdateBase):

diff --git a/server/tests/subscription/test_endpoints.py b/server/tests/subscription/test_endpoints.py
@@ -734,6 +734,11 @@ async def test_neither_organization_nor_repository(
                     "result in a very ugly output on the subscription page."
                 ),
             },
+            {
+                "is_tax_applicable": True,
+                "properties": {},
+                "description": "Th",
+            },
             {"description": "Subscription Benefit", "properties": {}},
         ],
     )