Minor Python 3.5+ improvements #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a rework of cadc78f that doesn't use six for Python 3.5+ support.
A reimplementation of nested for Python 3 from 43cdd22, using the already imported contextmanager from contextlib. This should silence linter warnings about the implementation method, but also be Python 3.4+ compatible and more future proof for changes in later Python versions.
ploxiln
reviewed
Apr 15, 2022
| @@ -195,7 +195,7 @@ def dict_contains(superset, subset): | |||
| """ | |||
| Assert that all key/val pairs in dict 'subset' also exist in 'superset' | |||
| """ | |||
| for key, value in subset.iteritems(): | |||
| for key, value in subset.items(): | |||
There was a problem hiding this comment.
hah - this wasn't noticed before, because nothing has used this helper function since 2011 (usage removed in 0194237)
There was a problem hiding this comment.
... if you open a pull request against the master branch which just deletes this function, I'd merge it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two small changes to the
req_py3branch:Implement nested using contextmanager
A reimplementation of nested for Python 3 from 43cdd22, using the already imported contextmanager from contextlib.
This should silence linter warnings about the implementation method, but also be Python 3.4+ compatible and more future proof for changes in later Python versions.
Fix test_tasks for Python 3
This is a rework of cadc78f that doesn't use six for Python 3.5+ support.