Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Cluster HoverData #7297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BSd3v
Copy link

@BSd3v BSd3v commented Dec 3, 2024

Adding hover and click data to clusters for maps.

It currently only emits the plotly_hover and plotly_click events, instead of providing the hoverData directly on screen, automatically.

Looking for feedback and assistance with how to get the hoverData to show.

@alexcjohnson

@gvwilson gvwilson added feature something new community community contribution P2 considered for next cycle labels Dec 4, 2024
@archmoj
Copy link
Contributor

archmoj commented Jan 2, 2025

Thanks very much for the PR.
Please add draftlogs/7297_fix.md for this PR as described here.

Please add a jasmine test in test/jasmine/tests/map_test.js for this feature as well.

Wondering if this fix may also be applied to mapbox?

@BSd3v
Copy link
Author

BSd3v commented Jan 2, 2025

@archmoj,

I believe that this can be applied to mapbox as well. From my understanding, it seems that map is an offshoot of mapbox.

@archmoj
Copy link
Contributor

archmoj commented Jan 6, 2025

@archmoj,

I believe that this can be applied to mapbox as well. From my understanding, it seems that map is an offshoot of mapbox.

That's true.
Although the mapbox traces would be removed in plotly.js v4, having this change for mapbox would be nice IMHO. cc: @gvwilson @ndrezn

BTW Let's start by adding the tests to map first.
Thank you @BSd3v

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution feature something new P2 considered for next cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants