Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

Revert "loader: revert #1544 to reduce risks" #1701

Merged
merged 5 commits into from
May 18, 2021
Merged

Revert "loader: revert #1544 to reduce risks" #1701

merged 5 commits into from
May 18, 2021

Conversation

lance6716
Copy link
Collaborator

Reverts #1657

@ti-chi-bot ti-chi-bot requested review from GMHDBJD and lichunzhu May 18, 2021 02:43
@lance6716 lance6716 mentioned this pull request May 18, 2021
Closed
@lance6716
Copy link
Collaborator Author

the conflict is merged in #1685 😂 I'm requesting ti-community-infra/tichi#539

@lance6716
Copy link
Collaborator Author

/run-compatibility-test

@lance6716
Copy link
Collaborator Author

@lichunzhu PTAL

@lance6716 lance6716 added the require-LGT1 for small PR, LGT1 is enough label May 18, 2021
lichunzhu
lichunzhu reviewed May 18, 2021
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

loader/loader.go Outdated
@@ -27,6 +26,8 @@ import (
"sync"
"time"

"golang.org/x/sync/errgroup"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combine this to L42~48

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make fmt is not good to sort imports 😂

@Ehco1996
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

@Ehco1996: Thanks for your review. The bot only counts /lgtm from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

lichunzhu
lichunzhu reviewed May 18, 2021
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label May 18, 2021
@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e401c26

@ti-chi-bot ti-chi-bot merged commit 5170f34 into release-2.0 May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lichunzhu lichunzhu lichunzhu left review comments

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

Assignees
No one assigned
Labels
require-LGT1 for small PR, LGT1 is enough size/XL status/can-merge status/LGT1 One reviewer already commented LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lance6716 @Ehco1996 @ti-chi-bot @lichunzhu