Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(namespaces): renamed \Null to \NoEffect for future comp… #1252

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"Enqueue\\Gps\\": "pkg/gps/",
"Enqueue\\JobQueue\\": "pkg/job-queue/",
"Enqueue\\Mongodb\\": "pkg/mongodb/",
"Enqueue\\Null\\": "pkg/null/",
"Enqueue\\NoEffect\\\\": "pkg/null/",
Steveb-p marked this conversation as resolved.
Show resolved Hide resolved
"Enqueue\\Pheanstalk\\": "pkg/pheanstalk/",
"Enqueue\\RdKafka\\": "pkg/rdkafka/",
"Enqueue\\Redis\\": "pkg/redis/",
Expand Down
2 changes: 1 addition & 1 deletion docs/transport/null.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ $ composer require enqueue/null

```php
<?php
use Enqueue\Null\NullConnectionFactory;
use Enqueue\NoEffect\NullConnectionFactory;

$connectionFactory = new NullConnectionFactory();

Expand Down
2 changes: 1 addition & 1 deletion pkg/amqp-bunny/Tests/AmqpConsumerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
use Bunny\Message;
use Enqueue\AmqpBunny\AmqpConsumer;
use Enqueue\AmqpBunny\AmqpContext;
use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullMessage;
use Enqueue\Test\ClassExtensionTrait;
use Enqueue\Test\WriteAttributeTrait;
use Interop\Amqp\Impl\AmqpMessage;
Expand Down
8 changes: 4 additions & 4 deletions pkg/amqp-ext/Tests/AmqpContextTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
use Enqueue\AmqpExt\AmqpContext;
use Enqueue\AmqpExt\AmqpProducer;
use Enqueue\AmqpExt\AmqpSubscriptionConsumer;
use Enqueue\Null\NullQueue;
use Enqueue\Null\NullTopic;
use Enqueue\NoEffect\NullQueue;
use Enqueue\NoEffect\NullTopic;
use Enqueue\Test\ClassExtensionTrait;
use Enqueue\Test\ReadAttributeTrait;
use Interop\Amqp\Impl\AmqpMessage;
Expand Down Expand Up @@ -124,7 +124,7 @@ public function testShouldThrowIfNotAmqpQueueGivenOnCreateConsumerCall()
$context = new AmqpContext($this->createExtChannelMock());

$this->expectException(InvalidDestinationException::class);
$this->expectExceptionMessage('The destination must be an instance of Interop\Amqp\AmqpQueue but got Enqueue\Null\NullQueue.');
$this->expectExceptionMessage('The destination must be an instance of Interop\Amqp\AmqpQueue but got Enqueue\NoEffect\NullQueue.');
$context->createConsumer(new NullQueue('aName'));
}

Expand All @@ -133,7 +133,7 @@ public function testShouldThrowIfNotAmqpTopicGivenOnCreateConsumerCall()
$context = new AmqpContext($this->createExtChannelMock());

$this->expectException(InvalidDestinationException::class);
$this->expectExceptionMessage('The destination must be an instance of Interop\Amqp\AmqpTopic but got Enqueue\Null\NullTopic.');
$this->expectExceptionMessage('The destination must be an instance of Interop\Amqp\AmqpTopic but got Enqueue\NoEffect\NullTopic.');
$context->createConsumer(new NullTopic('aName'));
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/amqp-lib/Tests/AmqpConsumerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

use Enqueue\AmqpLib\AmqpConsumer;
use Enqueue\AmqpLib\AmqpContext;
use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullMessage;
use Enqueue\Test\ClassExtensionTrait;
use Enqueue\Test\WriteAttributeTrait;
use Interop\Amqp\Impl\AmqpMessage;
Expand Down
4 changes: 2 additions & 2 deletions pkg/async-command/Tests/Functional/UseCasesTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
use Enqueue\AsyncCommand\RunCommand;
use Enqueue\AsyncCommand\RunCommandProcessor;
use Enqueue\Consumption\Result;
use Enqueue\Null\NullContext;
use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullContext;
use Enqueue\NoEffect\NullMessage;
use Interop\Queue\Message;
use PHPUnit\Framework\TestCase;

Expand Down
4 changes: 2 additions & 2 deletions pkg/async-event-dispatcher/Tests/AsyncListenerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
use Enqueue\AsyncEventDispatcher\AsyncListener;
use Enqueue\AsyncEventDispatcher\EventTransformer;
use Enqueue\AsyncEventDispatcher\Registry;
use Enqueue\Null\NullMessage;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullMessage;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Test\ClassExtensionTrait;
use Enqueue\Test\ReadAttributeTrait;
use Interop\Queue\Context;
Expand Down
4 changes: 2 additions & 2 deletions pkg/async-event-dispatcher/Tests/AsyncProcessorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
use Enqueue\AsyncEventDispatcher\EventTransformer;
use Enqueue\AsyncEventDispatcher\Registry;
use Enqueue\Consumption\Result;
use Enqueue\Null\NullContext;
use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullContext;
use Enqueue\NoEffect\NullMessage;
use Enqueue\Test\ClassExtensionTrait;
use Interop\Queue\Processor;
use PHPUnit\Framework\MockObject\MockObject;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

use Enqueue\AsyncEventDispatcher\EventTransformer;
use Enqueue\AsyncEventDispatcher\PhpSerializerEventTransformer;
use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullMessage;
use Enqueue\Test\ClassExtensionTrait;
use Interop\Queue\Context;
use Interop\Queue\Message;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
use Enqueue\Bundle\Tests\Functional\App\TestAsyncListener;
use Enqueue\Bundle\Tests\Functional\App\TestAsyncSubscriber;
use Enqueue\Bundle\Tests\Functional\WebTestCase;
use Enqueue\Null\NullContext;
use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullContext;
use Enqueue\NoEffect\NullMessage;
use Enqueue\Util\JSON;
use Interop\Queue\Processor;
use Symfony\Component\EventDispatcher\GenericEvent;
Expand Down
2 changes: 1 addition & 1 deletion pkg/enqueue/Resources.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
use Enqueue\Gearman\GearmanConnectionFactory;
use Enqueue\Gps\GpsConnectionFactory;
use Enqueue\Mongodb\MongodbConnectionFactory;
use Enqueue\Null\NullConnectionFactory;
use Enqueue\NoEffect\NullConnectionFactory;
use Enqueue\Pheanstalk\PheanstalkConnectionFactory;
use Enqueue\RdKafka\RdKafkaConnectionFactory;
use Enqueue\Redis\RedisConnectionFactory;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
use Enqueue\Client\Message;
use Enqueue\Consumption\Context\MessageReceived;
use Enqueue\Consumption\Result;
use Enqueue\Null\NullMessage;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullMessage;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Test\TestLogger;
use Interop\Queue\Consumer;
use Interop\Queue\Context as InteropContext;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
use Enqueue\Client\RouteCollection;
use Enqueue\Consumption\Context\MessageReceived;
use Enqueue\Consumption\MessageReceivedExtensionInterface;
use Enqueue\Null\NullMessage;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullMessage;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Test\ClassExtensionTrait;
use Interop\Queue\Consumer;
use Interop\Queue\Context as InteropContext;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
use Enqueue\Consumption\PostMessageReceivedExtensionInterface;
use Enqueue\Consumption\Result;
use Enqueue\Consumption\StartExtensionInterface;
use Enqueue\Null\NullMessage;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullMessage;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Test\ClassExtensionTrait;
use Enqueue\Util\Stringify;
use Interop\Queue\Consumer;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
use Enqueue\Client\DriverInterface;
use Enqueue\Consumption\Context\MessageReceived;
use Enqueue\Consumption\MessageReceivedExtensionInterface;
use Enqueue\Null\NullMessage;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullMessage;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Test\ClassExtensionTrait;
use Interop\Queue\Consumer;
use Interop\Queue\Context as InteropContext;
Expand Down
2 changes: 1 addition & 1 deletion pkg/enqueue/Tests/Client/DelegateProcessorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

use Enqueue\Client\Config;
use Enqueue\Client\DelegateProcessor;
use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullMessage;
use Enqueue\ProcessorRegistryInterface;
use Interop\Queue\Context;
use Interop\Queue\Processor;
Expand Down
6 changes: 3 additions & 3 deletions pkg/enqueue/Tests/Client/Driver/GenericDriverTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
use Enqueue\Client\Driver\GenericDriver;
use Enqueue\Client\DriverInterface;
use Enqueue\Client\MessagePriority;
use Enqueue\Null\NullMessage;
use Enqueue\Null\NullQueue;
use Enqueue\Null\NullTopic;
use Enqueue\NoEffect\NullMessage;
use Enqueue\NoEffect\NullQueue;
use Enqueue\NoEffect\NullTopic;
use Enqueue\Test\ClassExtensionTrait;
use Interop\Queue\Context;
use Interop\Queue\Message as InteropMessage;
Expand Down
4 changes: 2 additions & 2 deletions pkg/enqueue/Tests/Client/DriverFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
use Enqueue\Gps\GpsContext;
use Enqueue\Mongodb\MongodbConnectionFactory;
use Enqueue\Mongodb\MongodbContext;
use Enqueue\Null\NullConnectionFactory;
use Enqueue\Null\NullContext;
use Enqueue\NoEffect\NullConnectionFactory;
use Enqueue\NoEffect\NullContext;
use Enqueue\Pheanstalk\PheanstalkConnectionFactory;
use Enqueue\Pheanstalk\PheanstalkContext;
use Enqueue\RdKafka\RdKafkaConnectionFactory;
Expand Down
6 changes: 3 additions & 3 deletions pkg/enqueue/Tests/Client/RouterProcessorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
use Enqueue\Client\RouteCollection;
use Enqueue\Client\RouterProcessor;
use Enqueue\Consumption\Result;
use Enqueue\Null\NullContext;
use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullContext;
use Enqueue\NoEffect\NullMessage;
use Enqueue\Test\ClassExtensionTrait;
use Enqueue\Test\ReadAttributeTrait;
use Interop\Queue\Destination;
Expand Down Expand Up @@ -188,7 +188,7 @@ public function testShouldDoNotModifyOriginalMessage()

$result = $processor->process($message, new NullContext());

//guard
// guard
$this->assertEquals(Result::ACK, $result->getStatus());

$this->assertSame('theBody', $message->getBody());
Expand Down
2 changes: 1 addition & 1 deletion pkg/enqueue/Tests/ConnectionFactoryFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
use Enqueue\Gearman\GearmanConnectionFactory;
use Enqueue\Gps\GpsConnectionFactory;
use Enqueue\Mongodb\MongodbConnectionFactory;
use Enqueue\Null\NullConnectionFactory;
use Enqueue\NoEffect\NullConnectionFactory;
use Enqueue\Pheanstalk\PheanstalkConnectionFactory;
use Enqueue\RdKafka\RdKafkaConnectionFactory;
use Enqueue\Redis\RedisConnectionFactory;
Expand Down
4 changes: 2 additions & 2 deletions pkg/enqueue/Tests/Consumption/CallbackProcessorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
namespace Enqueue\Tests\Consumption;

use Enqueue\Consumption\CallbackProcessor;
use Enqueue\Null\NullContext;
use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullContext;
use Enqueue\NoEffect\NullMessage;
use Enqueue\Test\ClassExtensionTrait;
use Interop\Queue\Processor;
use PHPUnit\Framework\TestCase;
Expand Down
4 changes: 2 additions & 2 deletions pkg/enqueue/Tests/Consumption/Extension/LogExtensionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
use Enqueue\Consumption\PostMessageReceivedExtensionInterface;
use Enqueue\Consumption\Result;
use Enqueue\Consumption\StartExtensionInterface;
use Enqueue\Null\NullMessage;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullMessage;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Test\ClassExtensionTrait;
use Enqueue\Util\Stringify;
use Interop\Queue\Consumer;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
use Enqueue\Consumption\Extension\ReplyExtension;
use Enqueue\Consumption\PostMessageReceivedExtensionInterface;
use Enqueue\Consumption\Result;
use Enqueue\Null\NullMessage;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullMessage;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Test\ClassExtensionTrait;
use Interop\Queue\Consumer;
use Interop\Queue\Context;
Expand Down
2 changes: 1 addition & 1 deletion pkg/enqueue/Tests/Consumption/QueueConsumerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
use Enqueue\Consumption\ExtensionInterface;
use Enqueue\Consumption\QueueConsumer;
use Enqueue\Consumption\Result;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Test\ReadAttributeTrait;
use Enqueue\Tests\Consumption\Mock\BreakCycleExtension;
use Enqueue\Tests\Consumption\Mock\DummySubscriptionConsumer;
Expand Down
2 changes: 1 addition & 1 deletion pkg/enqueue/Tests/Consumption/ResultTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace Enqueue\Tests\Consumption;

use Enqueue\Consumption\Result;
use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullMessage;
use PHPUnit\Framework\TestCase;

class ResultTest extends TestCase
Expand Down
4 changes: 2 additions & 2 deletions pkg/enqueue/Tests/Router/RouteRecipientListProcessorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
namespace Enqueue\Tests\Router;

use Enqueue\Consumption\Result;
use Enqueue\Null\NullMessage;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullMessage;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Router\Recipient;
use Enqueue\Router\RecipientListRouterInterface;
use Enqueue\Router\RouteRecipientListProcessor;
Expand Down
2 changes: 1 addition & 1 deletion pkg/enqueue/Tests/Rpc/PromiseTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Enqueue\Tests\Rpc;

use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullMessage;
use Enqueue\Rpc\Promise;
use PHPUnit\Framework\TestCase;

Expand Down
6 changes: 3 additions & 3 deletions pkg/enqueue/Tests/Rpc/RpcClientTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

namespace Enqueue\Tests\Rpc;

use Enqueue\Null\NullContext;
use Enqueue\Null\NullMessage;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullContext;
use Enqueue\NoEffect\NullMessage;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Rpc\Promise;
use Enqueue\Rpc\RpcClient;
use Interop\Queue\Consumer;
Expand Down
2 changes: 1 addition & 1 deletion pkg/enqueue/Tests/Symfony/Client/ConsumeCommandTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
use Enqueue\Consumption\QueueConsumer;
use Enqueue\Consumption\QueueConsumerInterface;
use Enqueue\Container\Container;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Symfony\Client\ConsumeCommand;
use Enqueue\Test\ClassExtensionTrait;
use Interop\Queue\Consumer;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
use Enqueue\Client\Config;
use Enqueue\Client\Driver\GenericDriver;
use Enqueue\Client\RouteCollection;
use Enqueue\Null\NullContext;
use Enqueue\NoEffect\NullContext;
use Enqueue\Symfony\Client\SetupBrokerExtensionCommandTrait;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
use Enqueue\Client\RouteCollection;
use Enqueue\Consumption\ChainExtension;
use Enqueue\Consumption\QueueConsumerInterface;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Symfony\Client\ConsumeCommand;
use Enqueue\Symfony\Client\SimpleConsumeCommand;
use Enqueue\Test\ClassExtensionTrait;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
use Enqueue\Consumption\QueueConsumer;
use Enqueue\Consumption\QueueConsumerInterface;
use Enqueue\Container\Container;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Symfony\Consumption\ConsumeCommand;
use Enqueue\Test\ClassExtensionTrait;
use Interop\Queue\Consumer;
Expand Down
4 changes: 2 additions & 2 deletions pkg/fs/Tests/FsContextTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
use Enqueue\Fs\FsDestination;
use Enqueue\Fs\FsMessage;
use Enqueue\Fs\FsProducer;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Test\ClassExtensionTrait;
use Enqueue\Test\ReadAttributeTrait;
use Interop\Queue\Context;
Expand Down Expand Up @@ -116,7 +116,7 @@ public function testShouldThrowIfNotFsDestinationGivenOnCreateConsumer()
$context = new FsContext(sys_get_temp_dir(), 1, 0666, 100);

$this->expectException(InvalidDestinationException::class);
$this->expectExceptionMessage('The destination must be an instance of Enqueue\Fs\FsDestination but got Enqueue\Null\NullQueue.');
$this->expectExceptionMessage('The destination must be an instance of Enqueue\Fs\FsDestination but got Enqueue\NoEffect\NullQueue.');
$consumer = $context->createConsumer(new NullQueue('aQueue'));

$this->assertInstanceOf(FsConsumer::class, $consumer);
Expand Down
8 changes: 4 additions & 4 deletions pkg/fs/Tests/FsProducerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
use Enqueue\Fs\FsDestination;
use Enqueue\Fs\FsMessage;
use Enqueue\Fs\FsProducer;
use Enqueue\Null\NullMessage;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullMessage;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Test\ClassExtensionTrait;
use Interop\Queue\Exception\InvalidDestinationException;
use Interop\Queue\Exception\InvalidMessageException;
Expand All @@ -33,7 +33,7 @@ public function testThrowIfDestinationNotFsOnSend()
$producer = new FsProducer($this->createContextMock());

$this->expectException(InvalidDestinationException::class);
$this->expectExceptionMessage('The destination must be an instance of Enqueue\Fs\FsDestination but got Enqueue\Null\NullQueue.');
$this->expectExceptionMessage('The destination must be an instance of Enqueue\Fs\FsDestination but got Enqueue\NoEffect\NullQueue.');
$producer->send(new NullQueue('aQueue'), new FsMessage());
}

Expand All @@ -42,7 +42,7 @@ public function testThrowIfMessageNotFsOnSend()
$producer = new FsProducer($this->createContextMock());

$this->expectException(InvalidMessageException::class);
$this->expectExceptionMessage('The message must be an instance of Enqueue\Fs\FsMessage but it is Enqueue\Null\NullMessage.');
$this->expectExceptionMessage('The message must be an instance of Enqueue\Fs\FsMessage but it is Enqueue\NoEffect\NullMessage.');
$producer->send(new FsDestination(TempFile::generate()), new NullMessage());
}

Expand Down
Loading