Skip to content

Commit

Permalink
ci: decommission of html5validator
Browse files Browse the repository at this point in the history
The following issue won't be fixed:
Closes #541
Closes #760

Part of #1669
  • Loading branch information
php-coder committed Feb 9, 2024
1 parent e42e338 commit 6af463b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 35 deletions.
15 changes: 0 additions & 15 deletions .github/workflows/static-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -130,21 +130,6 @@ jobs:
- name: Run shellcheck
run: ./src/main/scripts/execute-command.sh shellcheck

run-html5validator:
name: Run html5validator
# https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on
runs-on: ubuntu-20.04
steps:
- name: Clone source code
uses: actions/[email protected] # https://github.com/actions/checkout
with:
# Whether to configure the token or SSH key with the local git config. Default: true
persist-credentials: false
- name: Install html5validator
run: pip3 install --user html5validator==0.4.2
- name: Run html5validator
run: ./src/main/scripts/execute-command.sh html5validator

run-ansible-lint:
name: Run ansible-lint
# https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on
Expand Down
20 changes: 0 additions & 20 deletions src/main/scripts/execute-command.sh
Original file line number Diff line number Diff line change
Expand Up @@ -52,25 +52,6 @@ case ${1:-} in
--batch-mode \
enforcer:enforce
;;
'html5validator')
# FIXME: remove ignoring of error about alt attribute after resolving #314
# @todo #109 Check src/main/config/nginx/503.*html by html5validator
# @todo #695 /series/import/request/{id}: use divs instead of table for elements aligning
exec html5validator \
--root "$ROOTDIR/src/main/webapp/WEB-INF/views" \
--no-langdetect \
--ignore-re \
'Attribute “(th|sec|togglz|xmlns):[a-z]+” not allowed' \
'Attribute “th:[-a-z]+” not allowed on element "body" at this point' \
'Attribute “(th|sec|togglz):[-a-z]+” is not serializable' \
'Attribute with the local name “xmlns:[a-z]+” is not serializable' \
--ignore \
'An "img" element must have an "alt" attribute' \
'Element "option" without attribute "label" must not be empty' \
'The "width" attribute on the "td" element is obsolete' \
'Attribute "loading" not allowed on element "img" at this point' \
--show-warnings
;;
'integration-tests')
exec "$MVN" \
--batch-mode \
Expand Down Expand Up @@ -127,7 +108,6 @@ case ${1:-} in
echo >&2 '- checkstyle'
echo >&2 '- codenarc'
echo >&2 '- enforcer'
echo >&2 '- html5validator'
echo >&2 '- integration-tests'
echo >&2 '- jest'
echo >&2 '- pmd'
Expand Down

0 comments on commit 6af463b

Please sign in to comment.