Skip to content

Commit

Permalink
ci: decomission of SpotBugs
Browse files Browse the repository at this point in the history
The following issue won't be fixed:
Closes #184
Closes #185
Closes #480
Closes #1190
Closes #1198
Closes #1258

Part of #1669
  • Loading branch information
php-coder committed Feb 25, 2024
1 parent cb0d680 commit 56f8f80
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 350 deletions.
32 changes: 0 additions & 32 deletions .github/workflows/static-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,35 +65,3 @@ jobs:
restore-keys: maven-repository-
- name: Run maven-enforcer-plugin
run: ./src/main/scripts/execute-command.sh enforcer

run-spotbugs:
name: Run SpotBugs
# https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on
runs-on: ubuntu-20.04
steps:
- name: Clone source code
uses: actions/[email protected] # https://github.com/actions/checkout
with:
# Whether to configure the token or SSH key with the local git config. Default: true
persist-credentials: false
- name: Install JDK
uses: actions/[email protected] # https://github.com/actions/setup-java
with:
distribution: 'adopt' # https://github.com/actions/setup-java#supported-distributions
java-version: '8' # https://github.com/actions/setup-java#supported-version-syntax
- name: Restore existing cache
uses: actions/[email protected] # https://github.com/actions/cache
with:
# https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#input-parameters-for-the-cache-action
key: maven-repository-${{ hashFiles('pom.xml') }}
path: ~/.m2/repository
restore-keys: maven-repository-
- name: Compile sources
run: >-
mvn \
--batch-mode \
-Denforcer.skip=true \
-DskipMinify \
compile
- name: Run SpotBugs
run: ./src/main/scripts/execute-command.sh spotbugs
15 changes: 0 additions & 15 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,6 @@
<slf4j.version>1.7.36</slf4j.version>

<spock.version>1.0-groovy-2.0</spock.version>
<spotbugs.plugin.version>3.1.11</spotbugs.plugin.version>

<!-- Redefine default value from spring-boot-dependencies in order to have the latest version -->
<!-- LATER: remove overriding once version from Spring Boot will match the used one -->
Expand Down Expand Up @@ -747,20 +746,6 @@

<plugins>

<!--
Usage:
./mvnw spotbugs:check (checks the sources and produces report to the console)
-->
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<version>${spotbugs.plugin.version}</version>
<configuration>
<includeTests>true</includeTests>
<excludeFilterFile>src/main/config/spotbugs-filter.xml</excludeFilterFile>
</configuration>
</plugin>

<plugin>
<groupId>com.mycila</groupId>
<artifactId>license-maven-plugin</artifactId>
Expand Down
297 changes: 0 additions & 297 deletions src/main/config/spotbugs-filter.xml

This file was deleted.

6 changes: 0 additions & 6 deletions src/main/scripts/execute-command.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,6 @@ case ${1:-} in
frontend:npm \
-Dfrontend.npm.arguments='install-ci-test'
;;
'spotbugs')
exec "$MVN" \
--batch-mode \
spotbugs:check
;;
'unit-tests')
exec "$MVN" \
--batch-mode \
Expand All @@ -63,7 +58,6 @@ case ${1:-} in
echo >&2 '- enforcer'
echo >&2 '- integration-tests'
echo >&2 '- jest'
echo >&2 '- spotbugs'
echo >&2 '- unit-tests'
exit 1
;;
Expand Down

0 comments on commit 56f8f80

Please sign in to comment.