Skip to content

Commit

Permalink
refactor: remove unused Random.listOfEntityWithParentDto() method
Browse files Browse the repository at this point in the history
Should be in 1d7c82d commit.

The following issue won't be fixed:
Closes #926

Part of #1668
  • Loading branch information
php-coder committed Mar 13, 2024
1 parent c10249b commit 54b9e60
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 26 deletions.
7 changes: 0 additions & 7 deletions src/test/java/ru/mystamps/web/service/TestObjects.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
*/
package ru.mystamps.web.service;

import ru.mystamps.web.common.EntityWithParentDto;
import ru.mystamps.web.common.LinkEntityDto;
import ru.mystamps.web.feature.account.AddUserDbDto;
import ru.mystamps.web.feature.account.UserDetails;
Expand Down Expand Up @@ -127,12 +126,6 @@ public static EntityWithIdDto createEntityWithIdDto() {
return new EntityWithIdDto(Random.id(), TEST_ENTITY_NAME);
}

public static EntityWithParentDto createEntityWithParentDto() {
String name = Random.categoryName();
String parentName = Random.participantGroupName();
return new EntityWithParentDto(Random.id().toString(), name, parentName);
}

public static SeriesSalesParsedDataDbDto createSeriesSalesParsedDataDbDto() {
SeriesSalesParsedDataDbDto dto = new SeriesSalesParsedDataDbDto();

Expand Down
19 changes: 0 additions & 19 deletions src/test/java/ru/mystamps/web/tests/Random.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import io.qala.datagen.RandomShortApi;
import org.apache.commons.lang3.StringUtils;
import ru.mystamps.web.common.Currency;
import ru.mystamps.web.common.EntityWithParentDto;
import ru.mystamps.web.common.SlugUtils;
import ru.mystamps.web.feature.account.AccountValidation;
import ru.mystamps.web.feature.category.CategoryValidation;
Expand Down Expand Up @@ -166,12 +165,6 @@ public static String participantName() {
).english();
}

// @todo #738 Random.participantGroupName(): make the generated names conform to
// the validation rules (when they will appear)
public static String participantGroupName() {
return name();
}

public static String sellerName() {
return participantName();
}
Expand Down Expand Up @@ -241,18 +234,6 @@ public static List<EntityWithIdDto> listOfEntityWithIdDto() {
);
}

public static List<EntityWithParentDto> listOfEntityWithParentDto() {
final int minSize = 1;
final int maxSize = 3;
int size = integer(minSize, maxSize);
return sampleMultiple(
size,
TestObjects.createEntityWithParentDto(),
TestObjects.createEntityWithParentDto(),
TestObjects.createEntityWithParentDto()
);
}

public static String jsoupLocator() {
return sample("#id", "a[href]", "img[src$=.png]", "div#logo");
}
Expand Down

0 comments on commit 54b9e60

Please sign in to comment.