feat: Add TypeScript support #9550
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! |
dblythy
force-pushed
the
feat/typescript
branch
from
722576b to
c098c1b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #9550 +/- ##
==========================================
- Coverage 93.51% 93.50% -0.02%
==========================================
Files 186 186
Lines 14807 14802 -5
==========================================
- Hits 13847 13840 -7
- Misses 960 962 +2 ☔ View full report in Codecov by Sentry. |
mtrezza
approved these changes
Jan 21, 2025
| ["@babel/preset-env", { | ||
| "targets": { | ||
| "node": "14" | ||
| "node": "18" |
| "lint-fix": "eslint --fix --cache ./", | ||
| "build": "babel src/ -d lib/ --copy-files", | ||
| "build": "babel src/ -d lib/ --copy-files --extensions '.ts,.js'", | ||
| "build:types": "tsc && prettier --write 'types/{**/*,*}.ts' && npm run lint-fix", |
There was a problem hiding this comment.
Why does building types require prettier and lint-fix?
| "lint-fix": "eslint --fix --cache ./", | ||
| "build": "babel src/ -d lib/ --copy-files", | ||
| "build": "babel src/ -d lib/ --copy-files --extensions '.ts,.js'", | ||
| "build:types": "tsc && prettier --write 'types/{**/*,*}.ts' && npm run lint-fix", |
There was a problem hiding this comment.
Could you please add a test:types script and a CI job for it, like we have in the JS SDK? I think you can just copy both from https://github.com/parse-community/Parse-SDK-JS/pull/1985/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Closes: #7334
Approach
Note: The "options" and docs files that are generated are not currently compatible, as the babel plugin will need to be updated to support the new TS format.
Tasks