refactor: Bump flow-bin from 0.119.1 to 0.258.1 #9516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/flow-bin-0.258.1
branch
3 times, most recently
from
fb59073 to
066f9b2
Compare
|
@mtrezza there seems to be a large number of breaking changes on flow, probably 500+ lines of code change. Not sure it's worth it, as Typescript will replace flow anyway. Seems that:
|
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/flow-bin-0.258.1
branch
2 times, most recently
from
bff8b41 to
dc88ff9
Compare
|
So we ultimately need to convert Parse Server to TS, is that the conclusion? |
|
Considering the work that would be required in updating flow, i'm not convinced it's worth it considering we are probably moving in the TS direction anyway (which will lead to a more natural typing) |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/flow-bin-0.258.1
branch
2 times, most recently
from
ff93cfb to
50f63f1
Compare
|
If this upgrade is not necessary and we don't see any other disadvantages then I agree that we want to avoid double work. So let's ignore this upgrade for now and bump #7334. |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/flow-bin-0.258.1
branch
from
50f63f1 to
f6315f9
Compare
Bumps [flow-bin](https://github.com/flowtype/flow-bin) from 0.119.1 to 0.258.1. - [Release notes](https://github.com/flowtype/flow-bin/releases) - [Commits](https://github.com/flowtype/flow-bin/commits) --- updated-dependencies: - dependency-name: flow-bin dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/flow-bin-0.258.1
branch
from
f6315f9 to
8e0727d
Compare
|
Superseded by #9553. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps flow-bin from 0.119.1 to 0.258.1.
Commits
Maintainer changes
This version was pushed to npm by flowtype, a new releaser for flow-bin since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)