Add support for Aventus chains and allow force decorating relay chainspec (useful for solo chains) #1838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-keystore Configure Aventus keystore settings and allow force decorating relay chainspec
pepoviola
approved these changes
Aug 2, 2024
|
Hi @pepoviola not sure how I can resolve the CI errors. Can you please help or give me some direction? |
|
Hi @nahuseyoum, sorry about the delay. This felt off my notifications. Loos good to me, can you update your branch with main to recheck and merge? |
Thanks @pepoviola I have updatedmy branch with main. |
pepoviola
reviewed
Dec 31, 2024
package-lock.json
Outdated
There was a problem hiding this comment.
Hi @nahuseyoum, thanks for the update. Can you remove this file?, the lock file is under javascript dir.
Thanks!
There was a problem hiding this comment.
Also, you need to bring back the lock file under javascript directory.
Thanks!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.