Fixes API breaking changes. #557
Conversation
Superhepper
force-pushed
the
7.x.y-keep-api-intact
branch
from
3339b0e to
bd3bbaa
Compare
Superhepper
force-pushed
the
7.x.y-keep-api-intact
branch
2 times, most recently
from
046f466 to
55fd6a0
Compare
|
@THS-on Did you have the time to check if changes would have any effect on the RSA 2048 keys? |
| @@ -228,8 +230,36 @@ pub fn load_ak( | |||
| Ok(key_handle) | |||
| } | |||
|
|
|||
| /// This creates an Attestation Key in the Endorsement hierarchy | |||
| /// This creates an Attestation Key in the Endorsement hierarchy. | |||
| pub fn create_ak<IKC: IntoKeyCustomization>( | |||
There was a problem hiding this comment.
I think it'd be good to mark one of them as #[deprecated] with a message.
There was a problem hiding this comment.
I was thinking about that. The problem is that the function will not be removed but it will have its arguments changed in the next major version.
So xx will have its arguments changed.
and xx_2 will be removed. So xx_2 is the function that we want people to use right now. But it will be removed so marking it deprecated here could cause a lot of confusion.
There was a problem hiding this comment.
Good point, so let's not do that. But a doc-comment WARNING note or something may still be a good idea? 🤔
There was a problem hiding this comment.
That is an excellent idea. I need to rephrase the comments any way because I could barely understand them my self when I tried to look at the code in the browser.
There was a problem hiding this comment.
I think I have managed to fix it now. Please have a last look at the comments so I have not made some embarrassing mistakes @wiktor-k @ionut-arm
There was a problem hiding this comment.
I think it looks really nice 👌
Superhepper
force-pushed
the
7.x.y-keep-api-intact
branch
from
55fd6a0 to
0d7c815
Compare
Signed-off-by: Jesper Brynolf <[email protected]>
Superhepper
force-pushed
the
7.x.y-keep-api-intact
branch
from
0d7c815 to
5590896
Compare
This is an attempt to avoid breaking the API in major version 7.