-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#78 and #72 Hide default params when showDefaults is False and the va… #112
base: master
Are you sure you want to change the base?
#78 and #72 Hide default params when showDefaults is False and the va… #112
Conversation
…faults is False and the values are equivalent to the default
|
WalkthroughThe changes in this pull request modify the logic for handling query parameters in the Changes
Possibly related PRs
Poem
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for sveltekit-search-params ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This would be 👍 to have, been fighting this for a couple of hours, thinking it was a bug it did not behave like this :) |
also want to voice my support for this PR (if it works, I have not tested it 😂). I use ssp with tanstack table to create sharable views of my data tables, where the state of the table is contained in the query parameters (seen here are the defaults): const params = queryParameters(
{
columnFilters: ssp.object<ColumnFiltersState>([
{ id: 'membership', value: ['active', 'passive'] }
]),
sorting: ssp.object<SortingState>([{ id: 'memberSince', desc: false }]),
pagination: ssp.object<PaginationState>({
pageIndex: 1,
pageSize: 10
}),
visibility: ssp.object<VisibilityState>({
email: false,
slackEmail: false,
phone: false,
memberSince: false
})
},
{
debounceHistory: 500,
showDefaults: false
}
); <DataTable {params} /> as you might have guessed this can become a bit noisy, even when simply incrementing the page once, because some of these are written to despite them being equal to the default values and without a patch like this they would be shown |
I'm not against this PR but I would need to port the code the the runes version. I will try to find a bit of time for this |
#78 and #72 Hide default params when showDefaults is False and the values are equivalent to the default.
Note: I didn't go deep into how the code works, but did this patch showing how I would expect the plugin to behave, and how the authors of #78 and #72 also expect it to behave as far as I can tell.
Maybe there's a better implementation but this was simple enough and seemed to do the trick. Tests didn't run when I pulled the repo so I didn't add new ones.
Summary by CodeRabbit