[CMSP-833] add wpms fixture tests #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not sure if this will actually work, i guess we run it and find out...
jazzsequence
force-pushed
the
CMSP-833-add-wpms-fixture-tests
branch
from
38f1e4f to
c57e0ad
Compare
which checks the project config for force-db-drop
jazzsequence
changed the title
|
I think the CircleCI pipeline is still showing up in checks because we hadn't removed it at the point when @rwagner00 had forked his branch and my branch is a fork from that. |
rwagner00
approved these changes
Jan 23, 2024
pwtyler
requested changes
Jan 23, 2024
| @@ -83,7 +85,7 @@ public function findLatestVersion($major, $tag_prefix, $update_parameters) | |||
| */ | |||
| public function update(WorkingCopy $originalProject, array $parameters) | |||
| { | |||
| $forceDbDrop = !empty($parameters['force-db-drop']) ?? false; | |||
| $forceDbDrop = (!empty($parameters['force-db-drop']) || $this->forceDbDrop) ?? false; | |||
There was a problem hiding this comment.
I hate this. This does not need to be a clever one liner.
Comment on lines
+181
to
+186
| // $path = $this->fixtures()->getPath('wpms'); | ||
| // $wp_repo = $this->fixtures()->forkTestRepo('wpms'); | ||
|
|
||
| // list all the files and directories at $path | ||
| // exec("set -e; echo 'dropping wp database via wp-cli'; wp db drop --yes --path=$path"); | ||
| // exit(1); |
Comment on lines
+275
to
+279
| public function getPath($project) | ||
| { | ||
| return $this->getConfig()->get("projects.$project.path"); | ||
| } | ||
|
|
There was a problem hiding this comment.
Only instance of this new function is commented out. Remove?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request addresses CMSP-833 which unblocks #118 (CMSP-628). This is a fork from #118 and will merge into #118.
Summary
WpCliUpdatewhich looks to theupdate-toolconfiguration file forforce-db-dropFixturesclass togetPath