Merge pull request #724 from pact-foundation/fix/rubocop-error-on-pg-…

…advisory-lock

fix: result will not be returned from ensure incase of an error also result variable is unused

lib/sequel/extensions/pg_advisory_lock.rb

@@ -3,6 +3,7 @@
 # locks to be registered because different threads running the same code
 # should not cause a Sequel::Error to be raised.
 # Also, I wanted it to use Concurrent::Hash for multi-threaded environments.
+# Made minor change in begin ensure block in with_advisory_lock method.
 
 require "sequel"
 require "zlib"
@@ -57,10 +58,9 @@ def with_advisory_lock(name, id = nil)
           synchronize do
             if get(Sequel.function(lock_function, *function_params))
               begin
-                result = yield
+                yield
               ensure
                 get(Sequel.function(UNLOCK_FUNCTION, *function_params))
-                result
               end
             end
           end