Fix zadd syntax and add support for dealing with partially corrupted datasets #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for your fork, it helped |
|
no problem. glad i could help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zadd
The zadd call was using an incorrect variable scheme. Reference
For redis-py 4.4 the existing function parameters were invalid, I suspect this was changed at some point in the past.
recommendation
Assuming my presumption is correct, it should be possible to prevent such problems caused by API changes from arising in the future by specifying the version (or version range) of the redis-py (redis) dependency.
corrupted data
I was dealing with an old legacy dataset which had null entries for types and values, with these changes such entries are ignored instead of causing an error.