Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): implement eslint:prefer-object-spread #8216

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

tbashiyy
Copy link
Contributor

@tbashiyy tbashiyy commented Jan 2, 2025

Copy link

graphite-app bot commented Jan 2, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Jan 2, 2025
Copy link

codspeed-hq bot commented Jan 2, 2025

CodSpeed Performance Report

Merging #8216 will not alter performance

Comparing tbashiyy:feat/eslint-prefer-object-spread (bafd07b) with main (574a242)

Summary

✅ 29 untouched benchmarks

Copy link
Contributor

@camchenry camchenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good addition to me. I think we need to add more testing around the tokenization and character handling though. The base functionality seems good, but I'm not confident if we're handling multi-byte characters correctly. We should try to avoid iterating over chars/bytes specifically, and use memchr where possible (for known single byte characters)

@tbashiyy tbashiyy requested review from camc314 and camchenry January 3, 2025 07:37
Copy link
Contributor

@camchenry camchenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is in an ok place to merge now, but I'd also want @camc314 to take a brief look at it as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants