-
-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): implement eslint:prefer-object-spread
#8216
base: main
Are you sure you want to change the base?
feat(linter): implement eslint:prefer-object-spread
#8216
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
CodSpeed Performance ReportMerging #8216 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good addition to me. I think we need to add more testing around the tokenization and character handling though. The base functionality seems good, but I'm not confident if we're handling multi-byte characters correctly. We should try to avoid iterating over chars/bytes specifically, and use memchr
where possible (for known single byte characters)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is in an ok place to merge now, but I'd also want @camc314 to take a brief look at it as well
implement eslint:prefer-object-spread
(ref: #479)