feat: Upgrade to Quince #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to address overhangio/tutor-mfe#122 As a consequence of this change, images will be tagged with a "-nightly" suffix. Next, we'll probably have to build them periodically in CI.
The package version number may not include the "-nightly" suffix. Otherwise, installation fails with: setuptools.extern.packaging.version.InvalidVersion: Invalid version: '15.0.7-nightly'
regisb
requested changes
Dec 6, 2023
tutorjupyter/patches/openedx-dockerfile-post-python-requirements
Outdated
Show resolved
Hide resolved
mhsiddiqui
force-pushed
the
quince
branch
4 times, most recently
from
77b65a8 to
68b18af
Compare
regisb
requested changes
Dec 8, 2023
regisb
force-pushed
the
quince
branch
3 times, most recently
from
2537c31 to
9d9fe3a
Compare
regisb
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are my notes of upgrade process for #2 :
Installed Tutor quince branch.
Installed the plugin from source, and checkout a branch quince.
Merged changes (if any) from the plugin nightly branch.
In the plugin’s setup.py, bumped the version of the “tutor” package that the plugin depends on.
In the about.py module, bumped the version number to the next major release (in our case: “v17.0.0”).
Enabled the plugin.
Built all the tutor images locally tutor config save && tutor images build all.
Replaced all instances of the previous release name (“palm/olive”) by the new one (“quince”) in the entire repo: git grep -i palm and git grep -i olive.
Did basic testing to check its working correctly