Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDPDEVTOOL-5870: Update to 21.00 Java Oracle Open JDK #866

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TheJorgeBorras
Copy link
Member

@TheJorgeBorras TheJorgeBorras commented Dec 24, 2024

CHANGES

Updated Suitecloud-CLI (Node-CLI) to allow both Java 17 and Java 21:

  • Java version validation now checks for multiple possible java versions (presented as before but in array form):
    SDK_REQUIRED_JAVA_VERSION: '17' -> SDK_COMPATIBLE_JAVA_VERSIONS: ['17', '21'],
  • Updated Error Messages to better output list of compatible Java Versions (in case of error)

**Updated VSCode Suitecloud Extension to allow both Java 17 and Java 21** * Java version validation now checks for multiple possible java versions (presented as before but in array form). * Updated Error Messages to better output list of compatible Java Versions (in case of error)




TESTING SUGGESTIONS (Things to keep in mind)

  • In both cases I recommend trying to modify the SDK_COMPATIBLE_JAVA_VERSIONS: ['17', '21'] and adding/subtracting different 'versions'.

For Suitecloud-CLI (Node-CLI):

  • On execution it will attempt to read the isJavaVersionValid on ./suite-sdk/suitecloud-sdk-settings.json. If this is set to true then correct Java Version Validation will be skipped (this needs to be continuously set to false in order for the validation code to be executed).

For VCode Suitecloud Extension:

  • Unlike Suitecloud-CLI, VSCode Suitecloud Extension doesn't have a global Parameter File (ApplicationConstants.js) where SDK_COMPATIBLE_JAVA_VERSIONS can be modified or read. Instead, it attempts to read the values set in the Suitecloud-CLI library code. In order to test the changes, one needs to update ApplicationConstants.js file that is read by the VSCode Suitecloud Extension since the installed version doesn't contain the changes made in this Pull Request.

Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

  • PR author: TheJorgeBorras

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Dec 24, 2024
@TheJorgeBorras TheJorgeBorras force-pushed the feature/PDPDEVTOOL-5870-Update-to-21.00-Java-Oracle-Open-JDK branch from c000ee1 to 4803417 Compare December 24, 2024 12:39
@TheJorgeBorras TheJorgeBorras force-pushed the feature/PDPDEVTOOL-5870-Update-to-21.00-Java-Oracle-Open-JDK branch from 4803417 to 7916bdd Compare December 24, 2024 12:44
@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants