PDPDEVTOOL-5870: Update to 21.00 Java Oracle Open JDK #866
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES
Updated Suitecloud-CLI (Node-CLI) to allow both Java 17 and Java 21:
SDK_REQUIRED_JAVA_VERSION: '17' -> SDK_COMPATIBLE_JAVA_VERSIONS: ['17', '21'],
**Updated VSCode Suitecloud Extension to allow both Java 17 and Java 21** * Java version validation now checks for multiple possible java versions (presented as before but in array form). * Updated Error Messages to better output list of compatible Java Versions (in case of error)
TESTING SUGGESTIONS (Things to keep in mind)
SDK_COMPATIBLE_JAVA_VERSIONS: ['17', '21']
and adding/subtracting different 'versions'.For Suitecloud-CLI (Node-CLI):
isJavaVersionValid
on./suite-sdk/suitecloud-sdk-settings.json
. If this is set totrue
then correct Java Version Validation will be skipped (this needs to be continuously set tofalse
in order for the validation code to be executed).For VCode Suitecloud Extension:
ApplicationConstants.js
) whereSDK_COMPATIBLE_JAVA_VERSIONS
can be modified or read. Instead, it attempts to read the values set in the Suitecloud-CLI library code. In order to test the changes, one needs to updateApplicationConstants.js
file that is read by the VSCode Suitecloud Extension since the installed version doesn't contain the changes made in this Pull Request.