-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OP#59913] Add couple missing locale keys #17357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for providing missing translation keys. I left two comments that would be nice to be addressed before we merge this change.
Also note that the tests are failing right now:
1) I18n files are normalized
Failure/Error: expect(non_normalized).to be_empty, error_message
The following files need to be normalized:
modules/storages/config/locales/en.yml
Please run `i18n-tasks normalize' to fix
I hope that running this rake task will fix the failures.
Note: I will probably not be around to merge these changes until beginning of next year. Rest assured that I will keep this tab open in my browser and make sure to look at this PR again once I get back to work.
Thanks for findings — fixed.
Interesting feature — it just moved one key little bit higher inside yaml. But still has inconsistency with quote style.
NP. We have saying used on whole December: "Let's do it after holidays" :) Some time it means May holidays :) |
Co-authored-by: Jan Sandbrink <[email protected]>
OP#59913
What are you trying to accomplish?
Add missing attribute in en locale so it could be translated via crowdin.