Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OP#59913] Add couple missing locale keys #17357

Merged
merged 13 commits into from
Jan 6, 2025
Merged

Conversation

top4ek
Copy link
Contributor

@top4ek top4ek commented Dec 4, 2024

OP#59913

What are you trying to accomplish?

Add missing attribute in en locale so it could be translated via crowdin.

@top4ek top4ek changed the title Add missing ldap_auth_source.filter_string attribute [OP#59913] Add missing locale keys Dec 5, 2024
@top4ek top4ek changed the title [OP#59913] Add missing locale keys [OP#59913] Add couple missing locale keys Dec 5, 2024
Copy link
Contributor

@NobodysNightmare NobodysNightmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing missing translation keys. I left two comments that would be nice to be addressed before we merge this change.

Also note that the tests are failing right now:

  1) I18n files are normalized
     Failure/Error: expect(non_normalized).to be_empty, error_message

       The following files need to be normalized:
         modules/storages/config/locales/en.yml
       Please run `i18n-tasks normalize' to fix

I hope that running this rake task will fix the failures.

Note: I will probably not be around to merge these changes until beginning of next year. Rest assured that I will keep this tab open in my browser and make sure to look at this PR again once I get back to work.

config/locales/en.yml Outdated Show resolved Hide resolved
config/locales/en.yml Outdated Show resolved Hide resolved
@top4ek top4ek marked this pull request as draft December 20, 2024 14:23
@top4ek
Copy link
Contributor Author

top4ek commented Dec 20, 2024

Thanks for findings — fixed.

I hope that running this rake task will fix the failures.

Interesting feature — it just moved one key little bit higher inside yaml. But still has inconsistency with quote style.

until beginning of next year

NP. We have saying used on whole December: "Let's do it after holidays" :) Some time it means May holidays :)

@top4ek top4ek marked this pull request as ready for review January 6, 2025 09:37
@NobodysNightmare NobodysNightmare merged commit aebb59e into opf:dev Jan 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants