Fix: undefined method serialized for nil in ldap tls option migration #17271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machisuji
changed the title
Generated by 🚫 Danger |
oliverguenther
approved these changes
Jan 10, 2025
…ad of throwing an error
…option migration the 'ldap_tls_options' setting does no longer exist and has therefore no format de fined in the current code we also fixed the value/deserialize to handle this more gracefully, but for good measure we also just pick the value directly here because that is more robust
oliverguenther
force-pushed
the
fix/undefined-method-serialized-for-nil-in-ldap-tls-option-migration
branch
from
86b30fa to
f6e5727
Compare
oliverguenther
deleted the
fix/undefined-method-serialized-for-nil-in-ldap-tls-option-migration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses a problem when migrating from OpenProject 12 to 14 or later.
Yet another example for why you should try to avoid model code in migrations.