Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented CPU plugin just-in-time emitter for NotEqual operation. #28257

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

geeky33
Copy link
Contributor

@geeky33 geeky33 commented Jan 2, 2025

Details:

Added NotEqual Operation JIT Emitter for ARM64 SIMD

Implemented fp32 NotEqual operation JIT emitter for ARM64 SIMD platform using NEON instructions for optimized element-wise comparison operations. Added new NotEqualEmitter class and integrated with ARM64 executor and kernel (modified create_eltwise_emitter and get_supported_precisions).

Included comprehensive unit tests and performance benchmarks. Verified against reference CPU implementation with proper handling of edge cases (NaN, infinity, denormals).

No breaking changes. Requires ARM64 platform with NEON SIMD support.

Tickets:

@geeky33 geeky33 requested review from a team as code owners January 2, 2025 20:31
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Jan 2, 2025
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Jan 2, 2025
@a-sidorova a-sidorova self-assigned this Jan 3, 2025
@a-sidorova a-sidorova added the platform: arm OpenVINO on ARM / ARM64 label Jan 3, 2025
@a-sidorova a-sidorova added this to the 2025.0 milestone Jan 3, 2025
Copy link
Contributor

@a-sidorova a-sidorova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geeky33 Thank you for the contribution! Please take a look at the failed Code-Style job and my single comment 😊

@a-sidorova
Copy link
Contributor

build_jenkins

@a-sidorova
Copy link
Contributor

@geeky33 there are still problems with code-style. Could you fix them please?

@a-sidorova a-sidorova modified the milestones: 2025.0, 2025.1 Jan 15, 2025
@geeky33
Copy link
Contributor Author

geeky33 commented Jan 21, 2025

@a-sidorova ma'am I have updated the code

please review it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin ExternalPR External contributor platform: arm OpenVINO on ARM / ARM64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue] [ARM]: Implement CPU plugin just-in-time emitter for NotEqual operation
3 participants