Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Support installation on SEV SNP confidential nodes #9395

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bgartzi
Copy link

@bgartzi bgartzi commented Jan 23, 2025

This patch series aims to support installing a cluster on AMD SEV SNP confidential nodes.
Previously, only AMD SEV nodes were supported, which were configured through the confidentialCompute configuration flag.
Now that GCP supports specifying the confidential instance type, we are letting users specify which node type (SEV/SEV-SNP) they would like to deploy the cluster on.

This series depend on the following patches:
kubernetes-sigs/cluster-api-provider-gcp#1410
openshift/api#2165

I will update the go.mod replace sections pointing to personal forks once they are accepted.

This will let choose sev or sev-snp as the confidential computing
technology of choice.

The way it behaves together with confidentialCompute is due to 2
reasons:
    - Backwards compatibility.
    - Mimicing the wave the GCP API behaves.
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 23, 2025
Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

Hi @bgartzi. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rwsu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant