Skip to content

Commit

Permalink
Merge pull request #9335 from miyamotoh/private-dns-service-url-must-…
Browse files Browse the repository at this point in the history
…end-with-v1

OCPBUGS-47504: Power VS: Private DNS service endpoint URL must end with /v1
  • Loading branch information
openshift-merge-bot[bot] authored Dec 21, 2024
2 parents 747b913 + b38ebf6 commit d2bb750
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/asset/installconfig/powervs/metadata.go
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ func leftInContext(ctx context.Context) time.Duration {
// SetDefaultPrivateServiceEndpoints sets service endpoint overrides as needed for Disconnected install.
func (m *Metadata) SetDefaultPrivateServiceEndpoints(ctx context.Context, overrides []configv1.PowerVSServiceEndpoint, cosRegion string, vpcRegion string) []configv1.PowerVSServiceEndpoint {
overrides = addOverride(overrides, string(configv1.IBMCloudServiceCOS), fmt.Sprintf("https://s3.direct.%s.cloud-object-storage.appdomain.cloud", cosRegion))
overrides = addOverride(overrides, string(configv1.IBMCloudServiceDNSServices), "https://api.private.dns-svcs.cloud.ibm.com")
overrides = addOverride(overrides, string(configv1.IBMCloudServiceDNSServices), "https://api.private.dns-svcs.cloud.ibm.com/v1")
overrides = addOverride(overrides, string(configv1.IBMCloudServiceIAM), "https://private.iam.cloud.ibm.com")
overrides = addOverride(overrides, "Power", fmt.Sprintf("https://private.%s.power-iaas.cloud.ibm.com", vpcRegion)) // FIXME confiv1.IBMCloudServicePower?
overrides = addOverride(overrides, string(configv1.IBMCloudServiceResourceController), "https://private.resource-controller.cloud.ibm.com")
Expand Down

0 comments on commit d2bb750

Please sign in to comment.