Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-48366: Clean backport of transit subnets to 4.13 #2144

Open
wants to merge 1 commit into
base: release-4.13
Choose a base branch
from
Open

OCPBUGS-48366: Clean backport of transit subnets to 4.13 #2144

wants to merge 1 commit into from

Conversation

pliurh
Copy link
Contributor

@pliurh pliurh commented Jan 14, 2025

Although transit switch doesn't exsit in 4.13. We need this flag to allow users to customize the value before upgrading to 4.14.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 14, 2025
@openshift-ci-robot
Copy link

@pliurh: This pull request references Jira Issue OCPBUGS-48323, which is invalid:

  • expected the bug to target the "4.13.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-48358 to target a version in 4.14.0, 4.14.z, but it targets "4.15.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Although transit switch doesn't exsit in 4.13. We need this flag to allow users to customize the value before upgrading to 4.14.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

Hello @pliurh! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 14, 2025
@openshift-ci openshift-ci bot requested review from jwforres and sjenning January 14, 2025 11:48
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pliurh
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ricky-rav
Copy link

@arghosh93 PTAL

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jan 16, 2025
Merged
@pliurh pliurh changed the title OCPBUGS-48323: Clean backport of transit subnets to 4.13 OCPBUGS-48366: Clean backport of transit subnets to 4.13 Jan 17, 2025
@openshift-ci-robot
Copy link

@pliurh: This pull request references Jira Issue OCPBUGS-48366, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-48323 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Although transit switch doesn't exsit in 4.13. We need this flag to allow users to customize the value before upgrading to 4.14.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pliurh
Clean backport of transit subnets to 4.13
920262c 
Although transit switch doesn't exsit in 4.13. We need this flag
to allow users to customize the value before upgrading to 4.14.

Because estimated rule cost total exceeding cost limit for entire
OpenAPIv3 schema, some x-kubernetes-validations are removed.

Signed-off-by: Peng Liu <[email protected]>
@pliurh pliurh force-pushed the transit_switch_subnet branch from 2e7b000 to 920262c Compare January 17, 2025 08:15
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

@pliurh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pliurh
Copy link
Contributor Author

pliurh commented Jan 20, 2025

/jira refresh

@openshift-ci-robot
Copy link

@pliurh: This pull request references Jira Issue OCPBUGS-48366, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-48323 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pliurh
Copy link
Contributor Author

pliurh commented Jan 20, 2025

/jira refresh

@openshift-ci-robot
Copy link

@pliurh: This pull request references Jira Issue OCPBUGS-48366, which is invalid:

  • expected dependent Jira Issue OCPBUGS-48323 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@zhaozhanqi
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 20, 2025
@openshift-ci-robot
Copy link

@zhaozhanqi: This pull request references Jira Issue OCPBUGS-48366, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-48323 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-48323 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 20, 2025
@openshift-ci openshift-ci bot requested a review from zhaozhanqi January 20, 2025 04:03
@zhaozhanqi
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 21, 2025
@openshift-ci-robot
Copy link

@pliurh: This pull request references Jira Issue OCPBUGS-48366, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-48323 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-48323 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

Although transit switch doesn't exsit in 4.13. We need this flag to allow users to customize the value before upgrading to 4.14.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

arghosh93
arghosh93 reviewed Jan 21, 2025
View reviewed changes
operator/v1/types_network.go
// default which is subject to change over time.
// The current default subnet is 100.88.0.0/16
// The subnet must be large enough to accomadate one IP per node in your cluster
// The value must be in proper IPV4 CIDR format
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated OpenAPI spec gets added to our public Openshift document. For that reason we should be mindful about what we add here as comment.

operator/v1/types_network.go
// The subnet must be large enough to accomadate one IP per node in your cluster
// The current default subnet is fd97::/64
// The value must be in proper IPV6 CIDR format
// Note that IPV6 dual addresses are not permitted
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated OpenAPI spec gets added to our public Openshift document. For that reason we should be mindful about what we add here as comment.

  • Interconnect is not supported in 4.13.
  • The subnet can not be changed at day 2.

@arghosh93
Copy link

Do we need testsuite like we did in 4.14?
8217209#diff-83d794e7ea816406ec17f0edc6c94251ffc4e0dfc6e7cf1046ce38fc901fb1e5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arghosh93 arghosh93 arghosh93 left review comments

@jwforres jwforres Awaiting requested review from jwforres

@sjenning sjenning Awaiting requested review from sjenning

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

Assignees
No one assigned
Labels
jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. qe-approved Signifies that QE has signed off on this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pliurh @openshift-ci-robot @ricky-rav @zhaozhanqi @arghosh93