-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-48078: Add ratcheting tests for PowerVS service endpoints #2142
base: master
Are you sure you want to change the base?
OCPBUGS-48078: Add ratcheting tests for PowerVS service endpoints #2142
Conversation
@JoelSpeed: This pull request references Jira Issue OCPBUGS-48078, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Hello @JoelSpeed! Some important instructions when contributing to openshift/api: |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: juliemathew. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JoelSpeed: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
If we had the ability to add these tests when the PR for these changes was merged, we would have caught this earlier.
This adds tests for both spec and status to show that the ratcheting validation we added for 4.18 is working.
Currently blocked on waiting for openshift/kubernetes#2167 to merge, and then publishing a new set of kubebuilder binaries from that.