Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipam, virt: graduate persistent ips feature gate to GA #2140

Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from

Conversation

maiqueb
Copy link
Contributor

@maiqueb maiqueb commented Jan 13, 2025

Signed-off-by: Miguel Duarte Barroso [email protected]
(cherry picked from commit b701a1f)

This is a manual cherry-pick w/ conflicts. But on generated files.

Signed-off-by: Miguel Duarte Barroso <[email protected]>
(cherry picked from commit b701a1f)
Copy link
Contributor

openshift-ci bot commented Jan 13, 2025

Hello @maiqueb! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 13, 2025
Copy link
Contributor

openshift-ci bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maiqueb
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jan 13, 2025

@maiqueb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp 6c554f1 link false /test e2e-gcp
ci/prow/e2e-aws-ovn 6c554f1 link true /test e2e-aws-ovn
ci/prow/verify 6c554f1 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@maiqueb
Copy link
Contributor Author

maiqueb commented Jan 22, 2025

/payload-aggregate periodic-ci-openshift-ovn-kubernetes-release-4.18-periodics-e2e-aws-ovn-virt-periodic 2

Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

@maiqueb: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@maiqueb
Copy link
Contributor Author

maiqueb commented Jan 22, 2025

/payload-aggregate periodic-ci-openshift-ovn-kubernetes-release-4.18-periodics-e2e-aws-ovn-virt-periodic 2

@JoelSpeed any idea why this didn't pick up any job ?

@JoelSpeed
Copy link
Contributor

Looking at sippy I only see the techpreview variant, did you mean to trigger the TP version?

@maiqueb
Copy link
Contributor Author

maiqueb commented Jan 22, 2025

Looking at sippy I only see the techpreview variant, did you mean to trigger the TP version?

Oh this means I have yet to backport the release PRs that add a non-TP lane, right ?

@JoelSpeed
Copy link
Contributor

I would say so yes

@maiqueb
Copy link
Contributor Author

maiqueb commented Jan 23, 2025

/payload-aggregate periodic-ci-openshift-ovn-kubernetes-release-4.18-periodics-e2e-aws-ovn-virt-periodic 2

Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

@maiqueb: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-ovn-kubernetes-release-4.18-periodics-e2e-aws-ovn-virt-periodic

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3e6e8ce0-d99d-11ef-857c-f077b3686f3e-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants