Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-48286: feature-gates - enable ServiceAccountTokenNodeBinding #2139

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

OCPBUGS-48286: feature-gates - enable ServiceAccountTokenNodeBinding #2139

wants to merge 2 commits into from
+9 −9

Conversation

ibihim
Copy link
Contributor

@ibihim ibihim commented Jan 10, 2025

What

Enable ServiceAccountTokenNodeBinding.

Why

It is available in Beta on Kubernetes.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

Hello @ibihim! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 10, 2025
@openshift-ci openshift-ci bot requested review from JoelSpeed and sjenning January 10, 2025 18:38
@ibihim ibihim changed the title feature-gates: enable ServiceAccountTokenNodeBinding OCPBUGS-48286: feature-gates - enable ServiceAccountTokenNodeBinding Jan 10, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 10, 2025
@openshift-ci-robot
Copy link

@ibihim: This pull request references Jira Issue OCPBUGS-48286, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What

Enable ServiceAccountTokenNodeBinding.

Why

It is available in Beta on Kubernetes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@deads2k
Copy link
Contributor

deads2k commented Jan 10, 2025

/lgtm
/approve

@deads2k deads2k added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 10, 2025
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 10, 2025
rtheis
rtheis approved these changes Jan 10, 2025
View reviewed changes
Copy link

@rtheis rtheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

@rtheis: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, ibihim, rtheis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibihim
Copy link
Contributor Author

ibihim commented Jan 11, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 11, 2025
@openshift-ci-robot
Copy link

@ibihim: This pull request references Jira Issue OCPBUGS-48286, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from wangke19 January 11, 2025 00:02
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c1a063b and 2 for PR HEAD b725bdd in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c1a063b and 2 for PR HEAD b725bdd in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c1a063b and 2 for PR HEAD b725bdd in total

@deads2k
Copy link
Contributor

deads2k commented Jan 13, 2025

tested upstream

/override ci/prow/verify

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 13, 2025

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/verify

In response to this:

tested upstream

/override ci/prow/verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ibihim
Copy link
Contributor Author

ibihim commented Jan 13, 2025

/test e2e-aws-ovn-hypershift

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c1a063b and 2 for PR HEAD b725bdd in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c1a063b and 2 for PR HEAD b725bdd in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c1a063b and 2 for PR HEAD b725bdd in total

@ibihim
Copy link
Contributor Author

ibihim commented Jan 15, 2025

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 52377f0 and 1 for PR HEAD b725bdd in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 52377f0 and 2 for PR HEAD b725bdd in total

3 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 52377f0 and 2 for PR HEAD b725bdd in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 52377f0 and 2 for PR HEAD b725bdd in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 52377f0 and 2 for PR HEAD b725bdd in total

@ibihim
Copy link
Contributor Author

ibihim commented Jan 16, 2025

/test e2e-aws-serial

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 52377f0 and 2 for PR HEAD b725bdd in total

@deads2k
Copy link
Contributor

deads2k commented Jan 16, 2025

/override ci/prow/verify

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/verify

In response to this:

/override ci/prow/verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 52377f0 and 2 for PR HEAD b725bdd in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 366ffb8 and 1 for PR HEAD b725bdd in total

@ibihim
Copy link
Contributor Author

ibihim commented Jan 20, 2025

/jira refresh

@openshift-ci-robot
Copy link

@ibihim: This pull request references Jira Issue OCPBUGS-48286, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xingxingxia

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from xingxingxia January 20, 2025 16:28
@ibihim
Copy link
Contributor Author

ibihim commented Jan 20, 2025

/test e2e-aws-serial

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ef08cf6 and 0 for PR HEAD b725bdd in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ef08cf6 and 2 for PR HEAD b725bdd in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ef08cf6 and 2 for PR HEAD b725bdd in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e6cc8f6 and 1 for PR HEAD b725bdd in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e6cc8f6 and 2 for PR HEAD b725bdd in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f7ed4f5 and 1 for PR HEAD b725bdd in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f7ed4f5 and 2 for PR HEAD b725bdd in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f7ed4f5 and 2 for PR HEAD b725bdd in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c21a6eb and 1 for PR HEAD b725bdd in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c21a6eb and 2 for PR HEAD b725bdd in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c21a6eb and 2 for PR HEAD b725bdd in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

@ibihim: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn b725bdd link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp b725bdd link false /test e2e-gcp
ci/prow/e2e-aws-serial-techpreview b725bdd link true /test e2e-aws-serial-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtheis rtheis rtheis approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@sjenning sjenning Awaiting requested review from sjenning

@wangke19 wangke19 Awaiting requested review from wangke19

@xingxingxia xingxingxia Awaiting requested review from xingxingxia

Assignees

@deads2k deads2k

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ibihim @openshift-ci-robot @deads2k @JoelSpeed @rtheis