Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Power VS: Revert 2076 due to ratchetting validation bug #2136

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Power VS: Revert 2076 due to ratchetting validation bug #2136

wants to merge 2 commits into from

Conversation

mjturek
Copy link
Contributor

@mjturek mjturek commented Jan 7, 2025

No description provided.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

Hello @mjturek! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@mjturek mjturek changed the title Powervs revert 2076 Power VS: Revert 2076 due to ratchetting validation bug Jan 7, 2025
@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 7, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mjturek
Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

JoelSpeed
JoelSpeed reviewed Jan 7, 2025
View reviewed changes
config/v1/types_infrastructure.go Outdated
@@ -1699,7 +1699,8 @@ type PowerVSServiceEndpoint struct {
// Power Cloud - https://cloud.ibm.com/apidocs/power-cloud
//
// +required
// +kubebuilder:validation:Enum=CIS;COS;COSConfig;DNSServices;GlobalCatalog;GlobalSearch;GlobalTagging;HyperProtect;IAM;KeyProtect;Power;ResourceController;ResourceManager;VPC
// +kubebuilder:validation:Required
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop this please

config/v1/types_infrastructure.go Outdated
@@ -1699,7 +1699,8 @@ type PowerVSServiceEndpoint struct {
// Power Cloud - https://cloud.ibm.com/apidocs/power-cloud
//
// +required
// +kubebuilder:validation:Enum=CIS;COS;COSConfig;DNSServices;GlobalCatalog;GlobalSearch;GlobalTagging;HyperProtect;IAM;KeyProtect;Power;ResourceController;ResourceManager;VPC
// +kubebuilder:validation:Required
// +kubebuilder:validation:Pattern=`^[a-z0-9-]+$`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you include capital letters here, then the installer could at least validate for the correct pattern for the enum and we could get closer to having this feature working

You could also split the service endpoint and have a status version with different validation, and only revert the validation of the status version of the struct

@mjturek mjturek force-pushed the powervs-revert-2076 branch from 3ae3636 to 82e6ba4 Compare January 7, 2025 20:26
@mjturek mjturek force-pushed the powervs-revert-2076 branch from 82e6ba4 to fb3a3b2 Compare January 7, 2025 22:06
@mjturek
Copy link
Contributor Author

mjturek commented Jan 7, 2025

/test e2e-gcp

@JoelSpeed
Copy link
Contributor

/retest-required

Can we add a validation check to the install so that it verifies the install config against the enum values we are removing?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

@mjturek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp fb3a3b2 link false /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@cheesesashimi cheesesashimi Awaiting requested review from cheesesashimi

@sjenning sjenning Awaiting requested review from sjenning

Assignees
No one assigned
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjturek @JoelSpeed