Skip to content

Commit

Permalink
Used fixed name for dummy ipv6 interface to avoid length issue (#1447)
Browse files Browse the repository at this point in the history
As tracked in #1124,
interface creation can fail if the name exceeds 15 characters. Ensure that
for long cluster name the dummy interface that is created will not exceed
this lenght by using a fixed name.
  • Loading branch information
bfournie authored Sep 9, 2022
1 parent 0a0ad85 commit 3a1289b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion 02_configure_host.sh
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ fi
# The IPv6 bridge interface will remain in DOWN state with NO-CARRIER unless an interface is added,
# so add a dummy interface to ensure the bridge comes up
if [[ -n "${EXTERNAL_SUBNET_V6}" ]] && [ ! "$INT_IF" ]; then
sudo ip link add name ${BAREMETAL_NETWORK_NAME}-dummy up master ${BAREMETAL_NETWORK_NAME} type dummy
sudo ip link add name bm-ipv6-dummy up master ${BAREMETAL_NETWORK_NAME} type dummy || true
fi

IPTABLES=iptables
Expand Down
4 changes: 2 additions & 2 deletions host_cleanup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ fi
if [ "$MANAGE_BR_BRIDGE" == "y" ]; then
sudo ifdown ${BAREMETAL_NETWORK_NAME} || true
sudo ip link delete ${BAREMETAL_NETWORK_NAME} || true
if [[ -d /sys/class/net/${BAREMETAL_NETWORK_NAME}-dummy ]]; then
sudo ip link delete ${BAREMETAL_NETWORK_NAME}-dummy || true
if [[ -d /sys/class/net/bm-ipv6-dummy ]]; then
sudo ip link delete bm-ipv6-dummy || true
fi
sudo rm -f /etc/sysconfig/network-scripts/ifcfg-${BAREMETAL_NETWORK_NAME}
fi
Expand Down

0 comments on commit 3a1289b

Please sign in to comment.