Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel Settings: Make long Channel UID fully visible #3027

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jan 19, 2025

Fix #3023

image image

Copy link

relativeci bot commented Jan 19, 2025

#2729 Bundle Size — 10.98MiB (~+0.01%).

8b2b2cd(current) vs d5b9863 main#2728(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes
                 Current
#2729
     Baseline
#2728
No change  Initial JS 1.9MiB 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
Change  Cache Invalidation 18.05% 17.39%
No change  Chunks 227 227
No change  Assets 250 250
Change  Modules 2952(+0.03%) 2951
No change  Duplicate Modules 154 154
No change  Duplicate Code 1.8% 1.8%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2729
     Baseline
#2728
No change  JS 9.19MiB 9.19MiB
Regression  CSS 867.33KiB (~+0.01%) 867.27KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch jimtng:channelid-wordwrapProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 merged commit 14a665f into openhab:main Jan 19, 2025
5 checks passed
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Jan 19, 2025
@florian-h05 florian-h05 added this to the 5.0 milestone Jan 19, 2025
@jimtng jimtng deleted the channelid-wordwrap branch January 19, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MainUI: Channel UID has fixed width and does not show full UID details of long UIDs.
2 participants