Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail of javadoc warnings #100

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

trask
Copy link
Member

@trask trask commented Nov 23, 2024

Currently fails with

/home/runner/work/semantic-conventions-java/semantic-conventions-java/semconv/src/main/java/io/opentelemetry/semconv/ErrorAttributes.java:39: warning: empty <p> tag
   * <p>
     ^
error: warnings found and -Werror specified
1 error
2 warnings

due to this empty <p>:

I checked the rendering and it looks like we can just remove that <p> and things render the same.

@jack-berg
Copy link
Member

I checked the rendering and it looks like we can just remove that

and things render the same.

See this related convo from when we switched to using weaver for codegen. @jsuereth ran into issues avoiding the empty <p> tags.

@trask
Copy link
Member Author

trask commented Dec 2, 2024

I think I've fixed this in weaver (open-telemetry/weaver#474), will revisit this PR after the next weaver release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants