-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTEP: Recording exceptions as log based events #4333
Open
lmolkova
wants to merge
15
commits into
open-telemetry:main
Choose a base branch
from
lmolkova:exceptions-on-logs-otep
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
changed the title
OTEP: Recording exceptions and errors with OpenTelemetry
OTEP: Recording exceptions as log based events
Dec 10, 2024
cijothomas
reviewed
Dec 10, 2024
cijothomas
reviewed
Dec 10, 2024
cijothomas
reviewed
Dec 10, 2024
I think this is a related issue: |
cijothomas
reviewed
Dec 10, 2024
cijothomas
reviewed
Dec 10, 2024
trask
reviewed
Dec 11, 2024
lmolkova
force-pushed
the
exceptions-on-logs-otep
branch
2 times, most recently
from
December 17, 2024 17:30
b06a09f
to
76c7d85
Compare
reyang
reviewed
Dec 20, 2024
lmolkova
force-pushed
the
exceptions-on-logs-otep
branch
from
December 27, 2024 17:42
5078c47
to
9bc6220
Compare
lmolkova
force-pushed
the
exceptions-on-logs-otep
branch
from
December 27, 2024 17:42
9bc6220
to
a306972
Compare
lmolkova
force-pushed
the
exceptions-on-logs-otep
branch
from
December 27, 2024 18:12
a306972
to
974505f
Compare
lmolkova
force-pushed
the
exceptions-on-logs-otep
branch
from
December 27, 2024 18:28
1a1ea49
to
5ddfd05
Compare
3 tasks
joaopgrassi
reviewed
Jan 2, 2025
Co-authored-by: Joao Grassi <[email protected]>
lmolkova
force-pushed
the
exceptions-on-logs-otep
branch
from
January 3, 2025 01:42
db27087
to
e9f38aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to open-telemetry/semantic-conventions#1536
Changes
Recording exceptions as span events is problematic since it
This OTEP provides guidance on how to record exceptions using OpenTelemetry logs focusing on minimizing duplication and providing context to reduce the noise.
If accepted, the follow-up spec changes are expected to replace existing (stable) documents:
Related OTEP(s) #CHANGELOG.md
file updated for non-trivial changesspec-compliance-matrix.md
updated if necessary