Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain empty tracer name as is instead of using default name #2486

Merged
merged 3 commits into from
Dec 31, 2024

Conversation

takaebato
Copy link
Contributor

@takaebato takaebato commented Dec 29, 2024

Fixes #2372

Changes

Ensures empty tracer names are retained, similar to #2334 and #2316.

After implementing this change, I realized the spec might not mention empty tracer names..
Advice on whether this change is necessary would be appreciated!

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

Copy link

linux-foundation-easycla bot commented Dec 29, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cijothomas / name: Cijo Thomas (5463b57)
  • ✅ login: takaebato / name: Takahiro Ebato (ea298ec, e5a7165)

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (56e7fae) to head (5463b57).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2486   +/-   ##
=====================================
  Coverage   77.8%   77.9%           
=====================================
  Files        123     123           
  Lines      22887   22925   +38     
=====================================
+ Hits       17824   17870   +46     
+ Misses      5063    5055    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takaebato takaebato changed the title retain empty tracer name Retain empty tracer name as is instead of using default name Dec 29, 2024
@takaebato takaebato marked this pull request as ready for review December 29, 2024 15:32
@takaebato takaebato requested a review from a team as a code owner December 29, 2024 15:32
@cijothomas
Copy link
Member

After implementing this change, I realized the spec might not mention empty tracer names..

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/api.md#get-a-tracer

@cijothomas cijothomas merged commit 17855be into open-telemetry:main Dec 31, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty tracer name must be retained
2 participants