Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure TLS with environment variables. #2465

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jvanz
Copy link

@jvanz jvanz commented Dec 23, 2024

Updates the opentelemetry-otlp crate to allow users to configure TLS using environment variables. Removing the need to crating the TLS config object and defining it with the with_tls_config method. In the same way other OTLP libraries does (e.g. go lang).

Partially fixes #774

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@jvanz jvanz force-pushed the tls-envvars branch 3 times, most recently from 50894e9 to 5031002 Compare December 24, 2024 16:12
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 2.81690% with 138 lines in your changes missing coverage. Please review.

Project coverage is 77.6%. Comparing base (17855be) to head (093a1ce).

Files with missing lines Patch % Lines
opentelemetry-otlp/src/exporter/tonic/mod.rs 0.0% 121 Missing ⚠️
opentelemetry-otlp/src/exporter/mod.rs 19.0% 17 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2465     +/-   ##
=======================================
- Coverage   77.9%   77.6%   -0.4%     
=======================================
  Files        123     123             
  Lines      22925   23027    +102     
=======================================
+ Hits       17870   17874      +4     
- Misses      5055    5153     +98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jvanz jvanz force-pushed the tls-envvars branch 2 times, most recently from 887a6a6 to 9458a03 Compare December 31, 2024 14:43
Updates the opentelemetry-otlp crate to allow users to configure TLS
using environment variables. Removing the need to crating the TLS config
object and defining it with the `with_tls_config` method. In the same
way other OTLP libraries does (e.g. go lang).

Signed-off-by: José Guilherme Vanz <[email protected]>
@jvanz jvanz marked this pull request as ready for review December 31, 2024 14:50
@jvanz jvanz requested a review from a team as a code owner December 31, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support all configuration of otlp exporter
1 participant