Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arch test to detect usage of shared internal code #6978

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jack-berg
Copy link
Member

Related to #6970.

This test prints out instances of shared internal code use. We could eventually remove all the detected instances, at which point we could fail the build instead of just printing.

But there's a long way to go. See this gist for the current state of affairs.

Note: I don't currently have a good way to tell when internal code is referenced for things like the SDK's implementation of of opentelemetry-api-incubating, which is switched to a compile dependency in #6944.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.01%. Comparing base (a3d807b) to head (96f172a).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6978      +/-   ##
============================================
+ Coverage     89.99%   90.01%   +0.02%     
- Complexity     6601     6602       +1     
============================================
  Files           730      730              
  Lines         19864    19864              
  Branches       1956     1956              
============================================
+ Hits          17877    17881       +4     
+ Misses         1391     1389       -2     
+ Partials        596      594       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant