Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delegates type t() to Task.t() #442

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

marcdel
Copy link
Contributor

@marcdel marcdel commented Dec 24, 2024

this is kind of silly, but i ran into a typespec error on a function that returns a Task when i aliased OpentelemetryProcessPropagator.Task.

Unknown type: OpentelemetryProcessPropagator.Task.t/0.

also, seems like dialyzer is unhappy on main, but i don't understand the issue.

i can test this change locally, but i don't remember how to reference my fork in another project. iirc it's a little different because they're subprojects or w/e?

:dialyzer.run error: Analysis failed with error:
{undef,[{prettypr,text,["'undefined'"],[]},
        {cerl_prettypr,lay_ann,2,[{file,"cerl_prettypr.erl"},{line,401}]},
        {cerl_prettypr,format,2,[{file,"cerl_prettypr.erl"},{line,261}]},
        {dialyzer_dataflow,signal_guard_failure,5,
                           [{file,"dialyzer_dataflow.erl"},{line,2477}]},
        {dialyzer_dataflow,bind_guard,3,
                           [{file,"dialyzer_dataflow.erl"},{line,1710}]},
        {dialyzer_dataflow,do_clause,7,
                           [{file,"dialyzer_dataflow.erl"},{line,1268}]},
        {dialyzer_dataflow,handle_clauses,9,
                           [{file,"dialyzer_dataflow.erl"},{line,1199}]},
        {dialyzer_dataflow,handle_case,3,
                           [{file,"dialyzer_dataflow.erl"},{line,932}]}]}
Last messages in the log cache:
  Reading files and computing callgraph... done in 0.02 secs
  Removing edges... done in 0.01 secs
Halting VM with exit status 1

@marcdel marcdel changed the title delegates type t() to Tast.t() delegates type t() to Task.t() Dec 26, 2024
@bryannaegele
Copy link
Collaborator

Does something similar need to be done for any of the supervisor stuff?

@danschultzer
Copy link
Contributor

For the prettypr error you just need to update the dialyxir dependency. It's on a rather old 1.2 version here.

@bryannaegele bryannaegele added the bug Something isn't working label Jan 3, 2025
@bryannaegele bryannaegele merged commit 3a9d546 into open-telemetry:main Jan 3, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants