fix(EntityFrameworkCore): server.address field to follow otel conventions #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions Fixes open-telemetry#2438 Update the `server.address` field in EntityFrameworkCore spans to populate with the server domain name without the `tcp` prefix. * Modify `src/OpenTelemetry.Instrumentation.EntityFrameworkCore/Implementation/EntityFrameworkDiagnosticListener.cs` to fetch the `host` and `port` properties from the `connection` object and set them to the `server.address` field, with a fallback to use the `dataSource` property if the `host` property is not available. * Update `src/OpenTelemetry.Instrumentation.EntityFrameworkCore/CHANGELOG.md` to reflect the changes made to the `server.address` field. * Add tests in `src/OpenTelemetry.Instrumentation.EntityFrameworkCore.Tests/EntityFrameworkInstrumentationTests.cs` to verify the `server.address` field is populated correctly without the `tcp` prefix. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/open-telemetry/opentelemetry-dotnet-contrib/issues/2438?shareId=XXXX-XXXX-XXXX-XXXX).
github-actions
bot
added
the
comp:instrumentation.entityframeworkcore
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Kielek
reviewed
Jan 2, 2025
Comment on lines
-1
to
-3
| // Copyright The OpenTelemetry Authors | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
| { | ||
| activity.AddTag(AttributeServerAddress, dataSource); | ||
| activity.AddTag(AttributeServerAddress, port); |
There was a problem hiding this comment.
Are you sure about attribute name here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2438
Update the
server.addressfield in EntityFrameworkCore spans to populate with the server domain name without thetcpprefix.Changes
src/OpenTelemetry.Instrumentation.EntityFrameworkCore/Implementation/EntityFrameworkDiagnosticListener.csto fetch thehostandportproperties from theconnectionobject and set them to theserver.addressfield, with a fallback to use thedataSourceproperty if thehostproperty is not available.src/OpenTelemetry.Instrumentation.EntityFrameworkCore/CHANGELOG.mdto reflect the changes made to theserver.addressfield.src/OpenTelemetry.Instrumentation.EntityFrameworkCore.Tests/EntityFrameworkInstrumentationTests.csto verify theserver.addressfield is populated correctly without thetcpprefix.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes