Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dataset with correction #214

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace dataset with correction #214

wants to merge 2 commits into from

Conversation

bdeadman
Copy link
Collaborator

Correction to Golden dataset.

Correction to Golden dataset.
Copy link

Change summary:

Filename Added Removed Changed
data/a1/ord_dataset-a12fa15d036d489c971b0b514caeae52.pb.gz 0 0 288
0 0 288

@bdeadman
Copy link
Collaborator Author

@spencerheins this will be the update to your dataset. After considering it some more I realised that my previous update proposal would have replaced all the reaction ids. This version has been done in such a way to maintain the ids.

I've documented the process in a new example Jupyter Notebook that I would like to include in ord-schema open-reaction-database/ord-schema#758. Let me know if you have any issues with it being used as an example.

Also note that I have attributed the record_modification to myself for two reasons 1) if there is a problem with the update they will come to me, and 2) I wanted to include some example person information in the example notebook.

@spencerheins
Copy link
Contributor

@bdeadman - I've got no issue with using this as an example in the JN. Thanks again for the assistance.

Copy link

Change summary:

Filename Added Removed Changed
data/a1/ord_dataset-a12fa15d036d489c971b0b514caeae52.pb.gz 0 0 288
0 0 288

@bdeadman bdeadman requested a review from connorcoley January 21, 2025 04:41
@bdeadman
Copy link
Collaborator Author

@connorcoley @skearnes - this is a correction to the Golden dataset from Wisconsin Madison. The update is documented in a Jupyter notebook (link in earlier comment) and involved updating some SMILES strings, and adding a record modified event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants