Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#18876: fix the wrong suggestion count being displayed on description #19483

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

#18876: fix the wrong suggestion count being displayed on description #19483

wants to merge 2 commits into from
+6 −1

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

Fixes #18876

  • I worked on fixing the wrong suggestion count being displayed on description
image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added UI UI specific issues To release Will cherry-pick this PR into the release branch labels Jan 22, 2025
@Ashish8689 Ashish8689 self-assigned this Jan 22, 2025
@Ashish8689 Ashish8689 requested a review from a team as a code owner January 22, 2025 13:34
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Jan 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.63% (40892/63274) 40.67% (16344/40189) 44.09% (4970/11272)

chirag-madlani
chirag-madlani requested changes Jan 23, 2025
View reviewed changes
...src/main/resources/ui/src/components/Suggestions/SuggestionsProvider/SuggestionsProvider.tsx
@@ -70,6 +70,7 @@ const SuggestionsProvider = ({ children }: { children?: ReactNode }) => {
try {
const { data } = await getSuggestionsList({
entityFQN,
limit: 500,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this impact the performance? I guess we may have count from backend instead passing higher limit. cc: @pmbrull @karanh37

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani requested changes

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display All Suggestions in UI for Table and Column Descriptions
3 participants
@Ashish8689 @chirag-madlani @ShaileshParmar11