Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: edit description permission for domain owner #19475

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: edit description permission for domain owner #19475

wants to merge 7 commits into from

Conversation

pranita09
Copy link
Contributor

@pranita09 pranita09 commented Jan 22, 2025 •
edited
Loading

Describe your changes:

Fix #19358

Fixed the edit-description permission issue for domain owner

Before:
Screenshot 2025-01-22 at 12 26 35 PM

After:

Screen.Recording.2025-01-22.at.12.27.05.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@ShaileshParmar11 ShaileshParmar11 added the safe to test Add this label to run secure Github workflows on PRs label Jan 22, 2025
@pranita09 pranita09 marked this pull request as ready for review January 22, 2025 13:15
@pranita09 pranita09 requested a review from a team as a code owner January 22, 2025 13:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.65% (40873/63221) 40.91% (16436/40176) 44.11% (4969/11266)

@ShaileshParmar11 ShaileshParmar11 added the To release Will cherry-pick this PR into the release branch label Jan 22, 2025
ShaileshParmar11
ShaileshParmar11 reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments

openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Domains.spec.ts Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Domains.spec.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Domain Owners Cannot Perform Edit Despite Correct Permissions
3 participants
@pranita09 @chirag-madlani @ShaileshParmar11