Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Existing custom properties getting removed on import of empty extension column #19234

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

sonika-shah
Copy link
Contributor

Describe your changes:

Fix -
When uploading a csv to the glossary, if no values are specified in the extension column, the existing custom properties are removed.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766 mohityadav766 merged commit 0d3393c into main Jan 5, 2025
15 of 21 checks passed
@mohityadav766 mohityadav766 deleted the fix-existing-cp-removal-on-import branch January 5, 2025 17:46
sonika-shah added a commit that referenced this pull request Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants