Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: dotnet pack release build #344

Merged
merged 1 commit into from
Jan 15, 2025
Merged

ci: dotnet pack release build #344

merged 1 commit into from
Jan 15, 2025

Conversation

jcsawyer
Copy link
Contributor

@jcsawyer jcsawyer commented Jan 15, 2025

This PR

  • Adds release configuration parameter to dotnet pack

Related Issues

Fixes #345

Notes

Using dotnet publish or dotnet pack compiles assemblies in debug mode unless you explicitly specify -c release. So the package is compiled without optimizations.

This is failing my builds which check for debug assemblies.
More info: https://garcia.in/posts/2021/pitfalls-of-unoptimized-nuget-packages/

Follow-up Tasks

How to test

@jcsawyer jcsawyer requested a review from a team as a code owner January 15, 2025 10:33
@jcsawyer jcsawyer force-pushed the main branch 2 times, most recently from 50b4b7d to d7461cb Compare January 15, 2025 11:52
@beeme1mr
Copy link
Member

Hey @jcsawyer, thanks for the PR and the link to the blog. Could you please sign off your commits? It's a requirement from the CNCF for accepting PRs.

To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~1 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin main

We can safely ignore the code coverage alert. I'm surprised changing a GitHub action has any impact on test coverage. We must not have our code coverage tool configured correctly.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.49%. Comparing base (1b5a0a9) to head (473793b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #344   +/-   ##
=======================================
  Coverage   85.49%   85.49%           
=======================================
  Files          38       38           
  Lines        1517     1517           
  Branches      154      154           
=======================================
  Hits         1297     1297           
  Misses        188      188           
  Partials       32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beeme1mr beeme1mr merged commit f994234 into open-feature:main Jan 15, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] NuGet Packages contain debug assemblies
4 participants