benchdnn: binary: update filling (maybe fixed MFDNN-12857) #2333
+30
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make src1 input integer only to avoid potential cancellation in sdpa patterns.
|
make test |
densamoilov
approved these changes
Jan 2, 2025
mgouicem
reviewed
Jan 6, 2025
| // Remove zeroes in src1 to avoid division by zero | ||
| if (input_idx == 1 && value == 0.0f) value = 1.0f; | ||
| mem_fp.set_elem(i, round_to_nearest_representable(dt, value)); | ||
| int min_val = MAX2(-8, static_cast<int>(lowest_dt(mem_dt.dt()))); |
There was a problem hiding this comment.
It seems:
- older code path would generate random data between [0; 16] for unsigned types whereas the patch generates data between [0; 8], is that expected?
- not specific to this patch: why use a fixed interval of 16 values instead of mem_dt range?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MFDNN-12857
Make src1 input integer only to avoid potential cancellation in sdpa patterns.