FDS-670 sorting issue with number column (#273)

ollionorg · May 20, 2024 · 21c10b5 · 21c10b5
1 parent 3b94874
commit 21c10b5
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/packages/flow-table/CHANGELOG.md b/packages/flow-table/CHANGELOG.md
@@ -2,6 +2,12 @@
 
 # Change Log
 
+## [2.4.5] - 2024-05-20
+
+### Bug Fixes
+
+- Sorting issue for number column in `f-table-schema`
+
 ## [2.4.4] - 2024-05-17
 
 ### Bug Fixes

diff --git a/packages/flow-table/package.json b/packages/flow-table/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ollion/flow-table",
-  "version": "2.4.4",
+  "version": "2.4.5",
   "description": "Table component for flow library",
   "module": "dist/flow-table.es.js",
   "main": "dist/flow-table.cjs.js",

diff --git a/packages/flow-table/src/components/f-table-schema/f-table-schema.ts b/packages/flow-table/src/components/f-table-schema/f-table-schema.ts
@@ -393,7 +393,7 @@ export class FTableSchema extends FRoot {
 					}
 					return 0;
 				} else if (typeof columnA === "number" && typeof columnB === "number") {
-					return this.sortOrder === "asc" ? columnB - columnA : columnA - columnB;
+					return this.sortOrder === "asc" ? columnA - columnB : columnB - columnA;
 				} else if (columnA instanceof Date && columnB instanceof Date) {
 					return this.sortOrder === "asc"
 						? (columnA as any) - (columnB as any)
@@ -442,7 +442,7 @@ export class FTableSchema extends FRoot {
 					? html`<f-div
 							padding="medium none"
 							style="position: sticky;left: 0px;z-index:3;"
-							.width=${this.offsetWidth + "px"}
+							.width=${this.offsetWidth ? `${this.offsetWidth}px` : `100%`}
 					  >
 							<f-search
 								.scope=${["all", ...Object.keys(this.data.header)]}